feat: align teams integration with slack parity#20544
Merged
Merged
Conversation
github-actions
Bot
temporarily deployed
to
app/preview/feat/teams-slack-parity
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
github-actions
Bot
temporarily deployed
to
api/preview/feat/teams-slack-parity
Contributor
|
API preview: https://pr-20544-api.vm6.ai |
hulh122
force-pushed
the
feat/teams-slack-parity
branch
from
42f027b to
8d4cc88
Compare
github-actions
Bot
temporarily deployed
to
app/preview/feat/teams-slack-parity
github-actions
Bot
temporarily deployed
to
api/preview/feat/teams-slack-parity
hulh122
force-pushed
the
feat/teams-slack-parity
branch
from
72fca5f to
5520188
Compare
hulh122
force-pushed
the
feat/teams-slack-parity
branch
from
5520188 to
b5fe90b
Compare
Contributor
Author
Code Review: PR #20544LGTM. I reviewed the Teams dispatch/connect/computer-use authorization paths and the rebased database migration metadata. I did not find blocking issues. Validation:
Local targeted API/platform tests were attempted, but this workspace initially had stale local DB/generated state; CI is the source of truth for the full matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dmWelcomeSentguard and propagate Teams conversation context through connect flowshelp,connect,disconnect,switch, andmodel, plus queued-run replies and Slack-like login/welcome copyagentOrgSlugand environment fieldsNotes
Testing
pnpm formatpnpm turbo run lintpnpm check-typespnpm -F api lintpnpm -F @vm0/app lintpnpm -F @vm0/api-contracts lintpnpm -F api check-typespnpm -F @vm0/app check-typespnpm -F @vm0/api-contracts check-typespnpm vitest --config vitest.config.ts --run src/signals/routes/__tests__/zero-teams-connect.test.ts src/signals/routes/__tests__/zero-teams-bot.test.ts src/signals/routes/__tests__/internal-callbacks-teams.test.tsfromapps/apipnpm vitest --config vitest.config.ts --run src/views/zero-page/__tests__/zero-teams-connect-page.test.tsxfromapps/platformgit diff --checkKnown local failures outside this change:
pnpm vitestfailed in non-Teams paths:chat-threads.bdd.test.ts,cron-summarize-memory.test.ts,webhooks-callbacks.bdd.test.ts,webhooks-notion.test.ts,zero-workflow-trigger-scheduler.test.ts, two connectors firewall metadata tests, plus an asyncImage is not definederror fromzero-jobs-page.test.tsx.pnpm knipfailed on the existing workspace unused-code baseline, including 7 unused files, 3 unused devDependencies, and 1608 unused exports.